return empty dict if config file is empty #811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanideByte
suggested changes
Dec 5, 2023
There was a problem hiding this comment.
I tested the code @sbendary25 provided on Windows and it works great. I think you could go a step further and have it repair the config file using the default one. Here is some tested code below that does that.
def get_config(path=user_config_path):
path = get_config_path(path)
config = None
with open(path, "r") as file:
config = yaml.safe_load(file)
if not config is None:
return config
if config is None:
# Deleting empty file because get_config_path copies the default if file is missing
os.remove(path)
path = get_config_path(path)
with open(path, "r") as file:
config = yaml.safe_load(file)
return config
|
added @CyanideByte suggestion a90cc8f |
Notnaton
reviewed
Dec 6, 2023
|
@Notnaton also added a message to inform user that default config is being applied |
|
@Notnaton bumping this to be closed and merged. |
|
Great work @sbendary25. And thanks @CyanideByte and @Notnaton for your suggestions and reviews. Merging now. (also thanks for your comments on the latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made:
yaml.safe_loadreturnsNonefrom theget_configfunction if the config file is empty. This change checks forNonevalue and instead returns{}soextend_configcall doesn't throw exception when config file is empty.Reference any relevant issue (Fixes #000)
#794
I have tested the code on the following OS:
AI Language Model (if applicable)